Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure that the mandatory fields required by the EDA API are respected within the modules. #319

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

alinabuzachis
Copy link
Contributor

Ensure that the mandatory fields required by the EDA API are respected within the modules.

Akasurde
Akasurde previously approved these changes Sep 16, 2024
…in the modules

Signed-off-by: Alina Buzachis <abuzachis@redhat.com>
Signed-off-by: Alina Buzachis <abuzachis@redhat.com>
@Alex-Izquierdo
Copy link
Contributor

Hi, @alinabuzachis I think the PR is incomplete unless your plan is to address it different PR's. According to the report:

  • Every module that has an organization name, it must be mandatory.

  • Activation module:

    • Decision_environment and rulebook_name are mandatory.
    • Project_id is not mandatory in the api since it comes from the rulebook id, but project_name must be mandatory in the module because the module needs it to find the rulebook id, otherwise it would fail if different projects has a rulebook with the same name.
  • Credential Type:

    • inputs and injectors are mandatory
  • Event streams:

    • event stream type and credential name are mandatory
  • Projects:

    • url is mandatory

@alinabuzachis
Copy link
Contributor Author

  • Decision_environment

I just rebased the PR and this seems to be the only thing missing. From what I can see, all the other requirements are already met.
For modules that require an organization_name, even if the organization_name is not added directly to required_if, it is required through this type of check (e.g., https://github.com/ansible/event-driven-ansible/blob/main/plugins/modules/project.py#L139)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Review
Development

Successfully merging this pull request may close these issues.

4 participants